-
-
Notifications
You must be signed in to change notification settings - Fork 844
added Jason Shi to Civic Tech Jobs page #8459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Jason Shi to Civic Tech Jobs page #8459
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: 2:00 PM - 3:00 PM, 1/9/2026 |
myronchen-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on finishing a good first issue.
Done Correctly
- The merge from and to branches have been correctly set.
- The issue has been correctly linked.
- The pull request title is named properly.
- The what and why in the pull request description is adequately described.
- The CodeQL alerts have been correctly checked off.
- Code changes have been correctly made.
- In the issue, you've correctly assigned yourself.
- In the issue, you've correctly set the project status.
- In the issue, action items have correctly been checked off.
Optional recommendations
- In the issue, your availability and ETA was not given. This should still be done even if you are able to complete it quickly.
- In your pull request, in the screenshots section for before changes were made, the placeholder text is still there. This caused the related screenshot to be out of the dropdown.
|
Availability: 3:00 PM - 5:00 PM, 1/10/2026 |
Mykola-Lopushenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bragelbytes,
Great job!
I approve your first issue. I have one recommendation, the same as the one @myronchen-git mentioned.
Done Correctly
- The merge from and to branches have been correctly set.
- The issue has been correctly linked.
- In the issue, you've correctly assigned yourself.
- The CodeQL alerts have been correctly checked off.
- In the issue, you've correctly set the project status.
- In the issue, action items have correctly been checked off.
Optional
In the issue, your availability and ETA was not given. This should still be done even if you are able to complete it quickly.
Fixes #8111
What changes did you make?
Added Jason Shi to the Civic Tech Jobs page
Why did you make the changes (we will use this info to test)?
We need to keep project information up to date so that visitors to the website can find accurate information.
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied