Add AWS to Civic Tech Jobs technologies#8569
Conversation
github-project-automation
bot
moved this to PR Needs review
in P: HfLA Website: Project Board
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
Review ETAL 9:30 PM 3/25/26 |
There was a problem hiding this comment.
code looks great and your pull request comment is correct, but I think you forgot to assign yourself on the original issue. It seems like you found the 2 GFIs you wanted to do and tried to assign yourself both at the same time. The Hack4LA bot auto unassigns you if it finds you're already assigned to another issue. It also seems like you forgot to post your ETA on the issue and availability. Fix those two things and I can come back and approve. Don't forget to click on the re request once you've made the changes.
To Be Fixed
- Assign yourself to original issue
- post ETA/Availability comment on original issue
github-project-automation
bot
moved this from PR Needs review
to PRs being reviewed
in P: HfLA Website: Project Board
There was a problem hiding this comment.
##What’s done correct:
- Pull Request has the correct branch name.
- No Linked Issues.
- You successfully added AWS to the Civic Tech Jobs Project
- AWS shows properly on the webpage in the Civic Tech Jobs Project technology section.
Great job on the code, but I am going to mimic what @jjam02 said regarding being unassigned to the original project and the fixes you need to make.
##What needs to be Fixed:
- Assign yourself to the original issue
- Post ETA/Availability comment on original issue.
Just request me when you fix those problems, and I'll approve this issue. Once again, great job on the project!
jjam02
left a comment
jjam02
left a comment
There was a problem hiding this comment.
good job fixing the above issues. Approved.
dvernon5
left a comment
dvernon5
left a comment
There was a problem hiding this comment.
Great job on the changes! Once again, thank you for your contributions! I'll approve and merge your code.
github-project-automation
bot
moved this from PRs being reviewed
to PRs ✅ waiting for merge team
in P: HfLA Website: Project Board
3 participants
Fixes #8333
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
![image]
Visuals after changes are applied
![image]
