Accessibility fixes 75#96
Merged
thekaveman merged 4 commits intohackforla:gh-pagesfrom May 9, 2019
Merged
Conversation
thekaveman
suggested changes
May 8, 2019
| <div class="location-img" style="background-image: url({{ item.image | absolute_url }})"></div> | ||
| <div class="location-details"> | ||
| <h3 class="location-header"></h3> | ||
| <strong>{{ item.title }}</strong> {{ item.event-date }} |
Member
There was a problem hiding this comment.
I'm actually thinking that the <h3> was supposed to wrap {{ item.title}} instead of the <strong> - can you do that instead?
Member
There was a problem hiding this comment.
Actually The original code looked as shown below. If you add the title into the h3 you loose the bold and the title will be a block item vs an inline tag. I think removing the h3 is the way to go.
Westside Mondays at 6:00 pm
thekaveman
approved these changes
May 9, 2019
thekaveman
pushed a commit
that referenced
this pull request
May 9, 2019
* delete empty h3 inside of hacknights location * added aria-label to social media icons * adds label for 'send us a message' input For #75
roslynwythe
added a commit
to roslynwythe/website
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes 3 accessibility issues brought up by "Wave" chrome extension
2 added aria-label to social media icons