added environment on vertical to project cards#986
added environment on vertical to project cards#986drubgrubby merged 5 commits intohackforla:gh-pagesfrom
Conversation
drubgrubby
left a comment
drubgrubby
left a comment
There was a problem hiding this comment.
You did this exactly right. Good job. However, the issue wasn't quite clear that it should have single quotes around 'Environment'. If you can add the single quote marks it will be perfect.
| tools: Docker, AWS, Observable | ||
| visible: true | ||
| status: Completed | ||
| vertical: Environment |
There was a problem hiding this comment.
The word Environment should be contained in single quotes: 'Environment'. This was not clear in the issue, but it is the standard. (I'm going to edit the issue now to show that).
| tools: Zeplin | ||
| visible: true | ||
| status: Active | ||
| vertical: Environment |
There was a problem hiding this comment.
Please change to: 'Environment'
| partner: LA Department of Transportation LADOT (https://ladot.lacity.org/) | ||
| visible: true | ||
| vertical: 'Under Development' | ||
| vertical: Environment |
There was a problem hiding this comment.
Please change to: 'Environment'
|
Also, the top line should read: "Fixes #894" , without the word "issue". |
|
Fixes #894 added quotes to Environment for metro-ontime.md on line 36, public-tree-map.md on line 58, and on line 76 to td-calculator.md |
DanielekPark
requested review from
drubgrubby
and removed request for
drubgrubby
|
@DanielekPark - Hey Daniel. I only see the original commit on this PR; I don't see the changes where you added the quotes. Usually if you push to the same branch it will add it to the PR. Can you check to see if pushed to the same branch as your previous commit, or if you pushed to a new branch, or perhaps haven't pushed the changes yet? We can look at this on Sunday if it's not clear. |
|
Daniel and I discussed this on Slack. He has completed the changes, but seems to have pushed it to a new branch so it's not showing up here. We will go over this at the dev meeting on Sunday. |
Trying to revert to pre-commit status due to duplicate issues
Matching current gh-pages
2 participants
fixes issue #894
Added environment to vertical on tdm-calculator.md file on line 76, to public-tree-map.md on line 58, and to metro-ontime.md on line 58