Change Toolkit SCSS (Part 3)#988
Conversation
|
I resolved the conflict and looked over the code. the figma has the header with the elements in a row and in desktop view. I vote that we merge this, and you can create another pr to fix that :)) |
I fixed the merge conflict incorrectly. My bad. Here is the fix
|
|
There was a problem hiding this comment.
Hi @TeddyTelanoff I am SO sorry about my delayed review, it was a hectic week- the page is getting close, thank you for making these edits!
The header does need work with the alignment before this PR can be merged (since this page is live and attached to our main nav), so FYI I've included more notes in the Figma on the Toolkit file (to the right of the previous notes) that will hopefully help make the necessary edits.
After that there might still be a few more adjustments necessary for mobile FYI.
Let me know if you have any questions! Sorry again about the delay!
|
I worked with Josh Bubar on the sccs for the toolkit page; we made a few changes to what was originally planned. We made some design decisions about the margins in the mobile view and we set the breakpoint at 850px instead of 479px. Please let me know what changes I should make. |
|
@TeddyTelanoff This page looks fantastic, great job!!! 🙌 [ I deleted this part - sorry my google chrome was acting up and I thought the mobile version of the header had issues, but I now see it's all good] |
4 participants
Fixed #960