feat(k8s): resolve service pods via Discovery API endpoint slices#270
Merged
Conversation
Services whose selector does not match pod app/clabernetes labels (or selectorless services) are now associated with their pods through the EndpointSlice collection: slices owned by the service map its endpoints' targetRef uids back to the listed pods. Hardening on top of the initial change, all pinned by tests: - list_namespaced_endpoint_slice used self.namespace (NameError before) - DiscoveryV1Api held on the controller like the other API clients - optional fields tolerated: endpoints, endpoint.target_ref (external IPs), metadata.owner_references (manually managed slices) - selectorless services (spec.selector None) no longer crash the listing - slice-mapped pods that do not belong to the requested lab are ignored (would KeyError on pod_services for NodePort links) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Services whose selector does not match pod app/clabernetes labels (or selectorless services) are now associated with their pods through the EndpointSlice collection: slices owned by the service map its endpoints' targetRef uids back to the listed pods.
Hardening on top of the initial change, all pinned by tests: