Skip to content

Bug fixes, new routes#179

Merged
pierreTklein merged 57 commits intomasterfrom
develop
Dec 2, 2018
Merged

Bug fixes, new routes#179
pierreTklein merged 57 commits intomasterfrom
develop

Conversation

@pierreTklein
Copy link
Copy Markdown
Member

Description

  • Return correct object from all get and post routes
  • Rolebindings are properly set upon account creation
  • Search validation fixed
  • Reset password email fixed
  • Added environment variable for location of hosted frontend
  • Bug fix with returning next

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional tests were placed in unit tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

pierreTklein and others added 30 commits November 22, 2018 01:21
…controller and middleware, update account service name
@pierreTklein pierreTklein requested review from YiFeiZhang2 and pashakondratyev and removed request for YiFeiZhang2 December 2, 2018 03:51
@pierreTklein pierreTklein merged commit cde350e into master Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants