Skip to content

Feature/role route #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Dec 29, 2018
Merged

Feature/role route #224

merged 33 commits into from
Dec 29, 2018

Conversation

@YiFeiZhang2
Copy link
Member

@YiFeiZhang2 YiFeiZhang2 commented Dec 20, 2018 •
edited
Loading

Description

Create the post route for roles.

Fixes #214

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Created local unit tests to check for success case, and failure due to authorization and authentication. Also checks that duplicate routes are allowed to be created.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

pierreTklein and others added 28 commits December 3, 2018 19:47
@pierreTklein
Merge pull request #191 from hackmcgill/develop
d5b977a 
Bug fixes, email templates, "change password" route.
@pierreTklein
Fix mention of docs to reflect new docs address
3c9c169
@pierreTklein
Merge pull request #192 from hackmcgill/fix-readme
6f47b3e 
Fix mention of docs to reflect new docs address
@pierreTklein
Merge pull request #208 from hackmcgill/develop
620003a 
Hopefully last merge into master before release
@YiFeiZhang2
version 1.1.0
2c54872
@YiFeiZhang2
version 1.1.1
a91b882
@YiFeiZhang2
allow booleanValidator to take comparator value for codeOfConduct
76ec217
@YiFeiZhang2
Create tests for false codeOfConduct in hacker
6080057
@YiFeiZhang2
Merge pull request #211 from hackmcgill/bug/204
d150a79 
Bug/204
@YiFeiZhang2
WIP role create route
edc4eab
@YiFeiZhang2
Change role service async calls to be in line with other services
adc8e6d
@YiFeiZhang2
Add role to vs code debugger
8fa1fa6
@YiFeiZhang2
Add role services
d251be6
@YiFeiZhang2
Fix false async
6285a34
@YiFeiZhang2
create role middleware
5c77e2b
@YiFeiZhang2
role error constants and add to app.js
0cff7ef
@YiFeiZhang2
create role controller
f7e3234
@YiFeiZhang2
WIP role route and role route tests
8d03389
@YiFeiZhang2
create /api/role/ route
9e1b19f
@YiFeiZhang2
Add success constants
0af5062
@YiFeiZhang2
Add tests
480326a
@YiFeiZhang2
Fix validator logic
6bed46f
@YiFeiZhang2
fix bugs with services with missing await
e5a2564
@YiFeiZhang2
comenting and documentation
925f465
@YiFeiZhang2
Merge branch 'develop' of https://github.com/hackmcgill/hackerAPI int…
5815152 
…o develop
@YiFeiZhang2
Merge branch 'develop' into feature/role-route
1fc89a0
@YiFeiZhang2
Add comments, change tests a little
1cc002e
@YiFeiZhang2
Remove duplicate check
0712836
pierreTklein
pierreTklein requested changes Dec 23, 2018
View reviewed changes
pierreTklein
pierreTklein reviewed Dec 28, 2018
View reviewed changes
@YiFeiZhang2 YiFeiZhang2 mentioned this pull request Dec 29, 2018
Closed
@YiFeiZhang2 YiFeiZhang2 merged commit d80da92 into develop Dec 29, 2018
@loreina loreina deleted the feature/role-route branch November 21, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierreTklein pierreTklein pierreTklein approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create route to create role

3 participants

@YiFeiZhang2 @pierreTklein