Skip to content

feat: Hacker location fields #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2021
Merged

feat: Hacker location fields #687

merged 2 commits into from
Jan 22, 2021

Conversation

@Tony9984
Copy link
Contributor

@Tony9984 Tony9984 commented Jan 21, 2021

Tickets:

  • N/A

List of changes:

  • Added optional fields for hacker location (timeZone, country, city) in the hacker schema
  • Updated documentation where needed

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New release
  • This change requires a documentation update

How has this been tested?

  • Ran the whole test suite
  • Made dummy POST & PATCH calls from Postman to test the location property

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@Tony9984 Tony9984 requested a review from logan-r January 21, 2021 22:31
@logan-r logan-r changed the title Feature/Hacker location fields feat: Hacker location fields Jan 22, 2021
@logan-r
Copy link
Member

logan-r commented Jan 22, 2021

#688

@Tony9984 Tony9984 merged commit ecb3acc into dev Jan 22, 2021
@Tony9984 Tony9984 deleted the feature/Location_fields branch January 22, 2021 00:24
logan-r added a commit that referenced this pull request Jan 23, 2021
@logan-r @Tony9984
release: version 3.1.2 (#689)
66b09e2 
* feat: Hacker location fields (#687)

* feat: add additional optional fields for hacker location

* feat: update documentation to include hacker location

* feat: update emails and bump version

Co-authored-by: Tony <36376980+Tony9984@users.noreply.github.com>
jamesxu123 added a commit that referenced this pull request Jun 21, 2021
@jamesxu123 @logan-r @Tony9984
fix: move ci/cd to github actions (#700)
e6f721e 
* release: version 3.1.2 (#689)

* feat: Hacker location fields (#687)

* feat: add additional optional fields for hacker location

* feat: update documentation to include hacker location

* feat: update emails and bump version

Co-authored-by: Tony <36376980+Tony9984@users.noreply.github.com>

* merge and resolve conflicts

* Create node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update app.js

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update package.json

* Update account.test.js

* Update account.test.js

* add elastic apm to see where tests are going wrong

* move apm to app.js so it gets picked up by test

* add apm env to gh workflow

* add missing envs

* remove debugging tools

* remove elastic apm

* run ci/cd on master as well

* Update .nvmrc

* Update package.json

* Delete .travis.yml

* Update package.json

Co-authored-by: Logan Ralston <logan.ralston@mail.mcgill.ca>
Co-authored-by: Tony <36376980+Tony9984@users.noreply.github.com>
logan-r added a commit that referenced this pull request Nov 29, 2021
@jamesxu123 @logan-r @Tony9984
fix: move ci/cd to github actions (#700)
023cab4 
* release: version 3.1.2 (#689)

* feat: Hacker location fields (#687)

* feat: add additional optional fields for hacker location

* feat: update documentation to include hacker location

* feat: update emails and bump version

Co-authored-by: Tony <36376980+Tony9984@users.noreply.github.com>

* merge and resolve conflicts

* Create node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update app.js

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update package.json

* Update account.test.js

* Update account.test.js

* add elastic apm to see where tests are going wrong

* move apm to app.js so it gets picked up by test

* add apm env to gh workflow

* add missing envs

* remove debugging tools

* remove elastic apm

* run ci/cd on master as well

* Update .nvmrc

* Update package.json

* Delete .travis.yml

* Update package.json

Co-authored-by: Logan Ralston <logan.ralston@mail.mcgill.ca>
Co-authored-by: Tony <36376980+Tony9984@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@logan-r logan-r logan-r approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tony9984 @logan-r