Skip to content

fix: move ci/cd to github actions #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Jun 21, 2021
Merged

fix: move ci/cd to github actions #700

merged 36 commits into from
Jun 21, 2021

Conversation

@jamesxu123
Copy link
Member

@jamesxu123 jamesxu123 commented Jun 19, 2021 •
edited
Loading

Tickets:

List of changes:

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Move CI/CD to GitHub Actions due to deprecation of travis-ci.org

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New release
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

logan-r and others added 6 commits January 22, 2021 21:07
@logan-r @Tony9984
release: version 3.1.2 (#689)
66b09e2 
* feat: Hacker location fields (#687)

* feat: add additional optional fields for hacker location

* feat: update documentation to include hacker location

* feat: update emails and bump version

Co-authored-by: Tony <36376980+Tony9984@users.noreply.github.com>
@logan-r
merge and resolve conflicts
6095685
@logan-r
merge and resolve conflicts
2829f54
@jamesxu123
Create node.js.yml
4a7c200
@jamesxu123
Update node.js.yml
7f5b91d
@jamesxu123
Update node.js.yml
09b6a67
@jamesxu123 jamesxu123 temporarily deployed to testing June 21, 2021 01:15 Inactive
@jamesxu123 jamesxu123 changed the title Create node.js.yml fix: move ci/cd to github actions Jun 21, 2021
@jamesxu123 jamesxu123 temporarily deployed to testing June 21, 2021 01:18 Inactive
@jamesxu123 jamesxu123 self-assigned this Jun 21, 2021
pierreTklein
pierreTklein reviewed Jun 21, 2021
View reviewed changes
.github/workflows/node.js.yml Outdated
push:
branches: [ dev ]
pull_request:
branches: [ dev ]
Copy link
Member

@pierreTklein pierreTklein Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about master branch? In case someone pushes to that branch in a rush right before the hackathon.

Copy link
Member Author

@jamesxu123 jamesxu123 Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that. I forgot about master!

@jamesxu123 jamesxu123 temporarily deployed to testing June 21, 2021 01:58 Inactive
krubenok
krubenok reviewed Jun 21, 2021
View reviewed changes
Copy link
Member

@krubenok krubenok left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks fine, but I think it'd be good to either merge #691 first or merge that branch into this so that we can have a full view of the impact on CI/CD before calling it good.

Also: travis.yml should be deleted as part of this PR.

Edit: this would also close #660

.idea/vcs.xml
Comment on lines 2 to 14
<component name="GithubSharedProjectSettings">
<option name="branchProtectionPatterns">
<list>
<option value="master" />
<option value="dev" />
</list>
</option>
</component>
<component name="VcsDirectoryMappings">
<mapping directory="$PROJECT_DIR$" vcs="Git" />
</component>
</project>
</project>
Copy link
Member

@krubenok krubenok Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone still use Jetbrains IDEs? Can this whole .idea folder be deleted?

Copy link
Member Author

@jamesxu123 jamesxu123 Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use PhpStorm, let's keep it for now.

@jamesxu123
Copy link
Member Author

jamesxu123 commented Jun 21, 2021

Overall, looks fine, but I think it'd be good to either merge #691 first or merge that branch into this so that we can have a full view of the impact on CI/CD before calling it good.

Also: travis.yml should be deleted as part of this PR.

Edit: this would also close #660

#691 is still in progress and it's estimated to take quite a long time because a lot of manual work is involved. Since Travis is deprecated, I believe it's best to get something functional in place so our other PRs won't be blocked. Good catch on the deletion of travis.yml though thanks!

@jamesxu123 jamesxu123 temporarily deployed to testing June 21, 2021 02:40 Inactive
@jamesxu123 jamesxu123 temporarily deployed to testing June 21, 2021 02:41 Inactive
@jamesxu123 jamesxu123 temporarily deployed to testing June 21, 2021 02:42 Inactive
@jamesxu123 jamesxu123 temporarily deployed to testing June 21, 2021 02:46 Inactive
krubenok
krubenok approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@krubenok krubenok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

Maybe time to investigate re-enabling dependabot now to start bailing out of dependency hell

@jamesxu123 jamesxu123 merged commit e6f721e into dev Jun 21, 2021
@jamesxu123 jamesxu123 deleted the feature/hac-32-investigate-new-cicd-system-for branch June 21, 2021 03:38
@jamesxu123 jamesxu123 mentioned this pull request Jun 21, 2021
Closed
logan-r added a commit that referenced this pull request Nov 29, 2021
@jamesxu123 @logan-r @Tony9984
fix: move ci/cd to github actions (#700)
023cab4 
* release: version 3.1.2 (#689)

* feat: Hacker location fields (#687)

* feat: add additional optional fields for hacker location

* feat: update documentation to include hacker location

* feat: update emails and bump version

Co-authored-by: Tony <36376980+Tony9984@users.noreply.github.com>

* merge and resolve conflicts

* Create node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update app.js

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update package.json

* Update account.test.js

* Update account.test.js

* add elastic apm to see where tests are going wrong

* move apm to app.js so it gets picked up by test

* add apm env to gh workflow

* add missing envs

* remove debugging tools

* remove elastic apm

* run ci/cd on master as well

* Update .nvmrc

* Update package.json

* Delete .travis.yml

* Update package.json

Co-authored-by: Logan Ralston <logan.ralston@mail.mcgill.ca>
Co-authored-by: Tony <36376980+Tony9984@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krubenok krubenok krubenok approved these changes

@chenxuan-zhou chenxuan-zhou Awaiting requested review from chenxuan-zhou

@meldunn meldunn Awaiting requested review from meldunn

@pengyk pengyk Awaiting requested review from pengyk

@pierreTklein pierreTklein Awaiting requested review from pierreTklein

Assignees

@jamesxu123 jamesxu123

Labels

ci/cd

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jamesxu123 @krubenok @pierreTklein @logan-r