Skip to content

Conversation

@logan-r
Copy link
Member

@logan-r logan-r commented Jan 23, 2021

Tickets:

  • HCK-

List of changes:

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Update confirmed, accepted, and declined emails' text copy
  • Support country, city and timezone as part of hacker application

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New release
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ x My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

Tony9984 and others added 2 commits January 21, 2021 19:24
* feat: add additional optional fields for hacker location

* feat: update documentation to include hacker location
@logan-r logan-r merged commit 66b09e2 into master Jan 23, 2021
jamesxu123 added a commit that referenced this pull request Jun 21, 2021
* release: version 3.1.2 (#689)

* feat: Hacker location fields (#687)

* feat: add additional optional fields for hacker location

* feat: update documentation to include hacker location

* feat: update emails and bump version

Co-authored-by: Tony <36376980+Tony9984@users.noreply.github.com>

* merge and resolve conflicts

* Create node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update app.js

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update package.json

* Update account.test.js

* Update account.test.js

* add elastic apm to see where tests are going wrong

* move apm to app.js so it gets picked up by test

* add apm env to gh workflow

* add missing envs

* remove debugging tools

* remove elastic apm

* run ci/cd on master as well

* Update .nvmrc

* Update package.json

* Delete .travis.yml

* Update package.json

Co-authored-by: Logan Ralston <logan.ralston@mail.mcgill.ca>
Co-authored-by: Tony <36376980+Tony9984@users.noreply.github.com>
logan-r added a commit that referenced this pull request Nov 29, 2021
* release: version 3.1.2 (#689)

* feat: Hacker location fields (#687)

* feat: add additional optional fields for hacker location

* feat: update documentation to include hacker location

* feat: update emails and bump version

Co-authored-by: Tony <36376980+Tony9984@users.noreply.github.com>

* merge and resolve conflicts

* Create node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update app.js

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update node.js.yml

* Update package.json

* Update account.test.js

* Update account.test.js

* add elastic apm to see where tests are going wrong

* move apm to app.js so it gets picked up by test

* add apm env to gh workflow

* add missing envs

* remove debugging tools

* remove elastic apm

* run ci/cd on master as well

* Update .nvmrc

* Update package.json

* Delete .travis.yml

* Update package.json

Co-authored-by: Logan Ralston <logan.ralston@mail.mcgill.ca>
Co-authored-by: Tony <36376980+Tony9984@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants