Notes-Table: `permission` is an enum and it misses values

[ccoenen]

I can't switch to protected or limited permissions. The setting will get accepted and is in place as long as someone has a pad open, but it is never committed to database, so the next time I open the same pad, the value is empty!

Here's why: My Notes table looks like this

MariaDB [hackmd]> show fields from Notes;
+------------------+----------------------------------------------+------+-----+---------+-------+
| Field            | Type                                         | Null | Key | Default | Extra |
+------------------+----------------------------------------------+------+-----+---------+-------+
| id               | char(36)                                     | NO   | PRI |         |       |
| shortid          | varchar(255)                                 | NO   | UNI | NULL    |       |
| alias            | varchar(255)                                 | YES  | UNI | NULL    |       |
| permission       | enum('freely','editable','locked','private') | YES  |     | NULL    |       |
| viewcount        | int(11)                                      | NO   |     | 0       |       |
| title            | text                                         | YES  |     | NULL    |       |
| content          | longtext                                     | YES  |     | NULL    |       |
| authorship       | text                                         | YES  |     | NULL    |       |
| lastchangeAt     | datetime                                     | YES  |     | NULL    |       |
| savedAt          | datetime                                     | YES  |     | NULL    |       |
| createdAt        | datetime                                     | NO   |     | NULL    |       |
| updatedAt        | datetime                                     | NO   |     | NULL    |       |
| deletedAt        | datetime                                     | YES  |     | NULL    |       |
| ownerId          | char(36)                                     | YES  |     | NULL    |       |
| lastchangeuserId | char(36)                                     | YES  |     | NULL    |       |
+------------------+----------------------------------------------+------+-----+---------+-------+

the type of permission seems wrong: the enum is missing "limited" and "protected". Can anyone else confirm this, or did I somehow break my installation?

Should this field be an enum in the first place? (the model suggests, that it is an enum).

Would there have to be a migration for that? From the currently existing migrations I would have guessed this should be a string instead (only migration to touch it appears to be update-to-0-3-1, which I probably never ran as it has been added after I installed my setup long before those "old" migrations were added. (and they obviously gave me problems while upgrading to 1.0.1-ce, as the tables and fields were already present). The feature seems to have been introduced here.

[SISheogorath]

I think here is actually just a migration missing.

Because the enum is never updated. People with newer instances won't experience this issue.

So adding a new migration should fix it.

PS: My instance is (iirc) younger and has all permissions in the enum.

[SISheogorath]

My instance is (iirc) younger and has all permissions in the enum.

[ccoenen]

But how are they created in the first place? How does sequelize learn about those fields in case of an empty database? Does it go different routes for initial setup than for migrations?

[ccoenen]

Also, this is another place, where Things look fine while using a document, but are actually not stored anywhere. We had a similar thing for #521, where only a part of the content got saved (which only surfaced once nobody was woking on a given document any longer).

There has to be some way of getting a "stored successfully" flag from the database, and in case it's not, or it produced warnings, we should burn down the editor. Before more data gets lost.

[ccoenen]

In this case, the problem might notbe "data loss", but "data leaked to people who were not supposed to see it", which i find to be equally distrurbing, depending on context.

[SISheogorath]

We actually apply some changes by HackMD itself after the migration by using: https://github.com/hackmdio/hackmd/blob/master/app.js#L232

https://sequelize.readthedocs.io/en/v3/docs/models-definition/#database-synchronization

[SISheogorath]

fixed by #757