Skip to content

Hide unused UI elements#101

Merged
jackycute merged 4 commits intohackmdio:masterfrom
janniklorenz:master
May 15, 2016
Merged

Hide unused UI elements#101
jackycute merged 4 commits intohackmdio:masterfrom
janniklorenz:master

Conversation

@janniklorenz
Copy link
Copy Markdown
Contributor

First of all, 0.4 is a great release, and the single database dependency now simplifies everything a lot.

2 Points I fixed:

  • Login button and message on history page only shows when we have a login method enabled
  • Dropbox and Google Drive export only available, when configured

@jackycute
Copy link
Copy Markdown
Member

jackycute commented Apr 23, 2016

Hi, Lorenz!
Thanks a lot for contributing these commits.

But I saw some meanless statement (if (googleDrive || googleDrive || github)) in
https://github.com/hackmdio/hackmd/pull/101/files#diff-7df48c29918a6d59c13923903e548cdaR36
https://github.com/hackmdio/hackmd/pull/101/files#diff-7df48c29918a6d59c13923903e548cdaR131
Could you fix that? I would like to merge this PR 😄

@janniklorenz
Copy link
Copy Markdown
Contributor Author

Sure, should be working now.

@jackycute
Copy link
Copy Markdown
Member

Hi, Lorenz
I feel like to merge this PR.
But I think of that the google Drive and dropbox drop-in are client-side features.
I'll need do some other commits after merge this PR.
So give me few days.
Thanks still.

@jackycute jackycute merged commit 55a1ba0 into hackmdio:master May 15, 2016
jackycute added a commit that referenced this pull request May 15, 2016
@janniklorenz janniklorenz mentioned this pull request May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants