Extend to support GitLab Authentication#118
Merged
jackycute merged 2 commits intohackmdio:masterfrom May 15, 2016
Merged
Conversation
Author
|
Sorry for open/close/open...wanted to use a more descriptive branch name. |
Member
|
Hi @jccrofty30 ! |
Author
|
Sure thing! Glad I could contribute. |
Add necessary dependency. Add baseURL parameter for self-hosted GitLab Add necessary require. Add block for GitLab auth. Fix typo Update font-awesome dependency for GitLab icon. Use a color closer to GitLab orange. More direct TODO
jccrofty30
force-pushed
the
gitlab_authentication
branch
from
0291fbb to
a3876df
Compare
Author
|
Fixed merge conflicts resulting from most recent updates. |
Member
|
Only one thing you missed right there, the gitlab avatar for user photo url. Based on |
Author
|
I did indeed. Will address in short-order. |
Author
|
Taken care of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit List:
Focus solely on authentication, saving/opening
snippetsnot addressed.