Skip to content

Add basics for secret management by Docker 1.13#325

Merged
a60814billy merged 2 commits intohackmdio:masterfrom
SISheogorath:feature/addSecrets
Mar 3, 2017
Merged

Add basics for secret management by Docker 1.13#325
a60814billy merged 2 commits intohackmdio:masterfrom
SISheogorath:feature/addSecrets

Conversation

@SISheogorath
Copy link
Copy Markdown
Contributor

See https://docs.docker.com/engine/swarm/secrets/

This is a first draft (That's why not all secrets are covers right now). I'm open for suggestions. Feel free to comment :)

@SISheogorath
Copy link
Copy Markdown
Contributor Author

@jackycute can you please take a first view? Just to make sure its not work that would find its way into the project.

As there are some very special "hacks" in it ;)

@jackycute jackycute requested a review from a60814billy January 26, 2017 09:01
@jackycute
Copy link
Copy Markdown
Member

It looks not bad.
Just few code styles need to be corrected.
Also I might need some docker users to test or tell how this needed.

@SISheogorath
Copy link
Copy Markdown
Contributor Author

Should be more or less finished here. Maybe docs in the README are missing

@SISheogorath SISheogorath changed the title WIP: Add basics for secret management by Docker 1.13 Add basics for secret management by Docker 1.13 Feb 10, 2017
Copy link
Copy Markdown
Member

@a60814billy a60814billy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SISheogorath ,
It looks good.

@a60814billy a60814billy merged commit bbde79c into hackmdio:master Mar 3, 2017
@SISheogorath SISheogorath deleted the feature/addSecrets branch October 19, 2017 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants