Skip to content

Extract CodeMirror instance#387

Merged
jackycute merged 8 commits intomasterfrom
cm-refactor
Mar 14, 2017
Merged

Extract CodeMirror instance#387
jackycute merged 8 commits intomasterfrom
cm-refactor

Conversation

@Yukaii
Copy link
Copy Markdown
Member

@Yukaii Yukaii commented Mar 13, 2017

Changes

  • Extract codemirror instance out of public/js/index.js to public/js/lib/editor/index.js
  • Extract common jquery ui node out of public/js/index to public/js/lib/editor/ui-elements.js
  • Extract wrapTextWith to public/js/lib/editor/utils.js
  • Change .editorconfig to meet our new standardjs indent favor
  • Patch more global variable to standardjs global variable list

@Yukaii Yukaii changed the title [WIP]: Extract CodeMirror instance Extract CodeMirror instance Mar 14, 2017
@jackycute
Copy link
Copy Markdown
Member

Pretty well, thanks @Yukaii

@jackycute jackycute merged commit f6bd238 into master Mar 14, 2017
@Yukaii Yukaii deleted the cm-refactor branch March 14, 2017 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants