Backend code refactoring - part 1 #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a60814billy
requested review from
Yukaii and
jackycute
and removed request for
Yukaii and
jackycute
Yukaii
reviewed
Apr 13, 2017
app.js
Outdated
| } | ||
| next() | ||
| }) | ||
| app.use(require('./lib/web/middleware/checkURiValid')) |
Member
There was a problem hiding this comment.
Would it be better if we use the camel case convention checkUrlValid ? 😕
Member
Author
There was a problem hiding this comment.
The middleware is checking uri only, I'll rename to checkURIValid
Contributor
|
Very nice! I like the new structure! |
Use class style implement write interface
use logger instead of logger.stream
extract check URi is valid, redirect without trailing slashes
* Separate different config source to each files * Freeze config object
a60814billy
force-pushed
the
BackendRefactor
branch
from
bb65adb to
d799978
Compare
Member
|
Thanks @a60814billy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.