Skip to content

Use abcjs on cdnjs#426

Merged
jackycute merged 1 commit intohackmdio:masterfrom
PeterDaveHello:cdnjs-integration
Apr 18, 2017
Merged

Use abcjs on cdnjs#426
jackycute merged 1 commit intohackmdio:masterfrom
PeterDaveHello:cdnjs-integration

Conversation

@PeterDaveHello
Copy link
Copy Markdown
Contributor

@ jackycute take a look please 😄

@jackycute
Copy link
Copy Markdown
Member

So the cdn must be imported as an optional resource.
I will leave some comments to guide you.

@jackycute
Copy link
Copy Markdown
Member

OK, so you did modified webpackConfig.js correctly, my mistake.

@jackycute
Copy link
Copy Markdown
Member

Thanks @PeterDaveHello

@jackycute jackycute merged commit 2a5a518 into hackmdio:master Apr 18, 2017
@PeterDaveHello PeterDaveHello deleted the cdnjs-integration branch April 18, 2017 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants