Skip to content

Conversation

@DoubleMalt
Copy link
Contributor

I added the possibility to authenticate against a Mattermost server. I was not sure about the version numbers, but I'm happy to change them to what they should be.

@SISheogorath
Copy link
Contributor

Awesome PR! Instantly coming with all needed changes. Very nice!

But as you see the CI process fails because of not following the coding standard. Can you fix this, please? Only minor issues ^^

You can test it yourself on your dev machine using npm test

Thanks a lot~

@SISheogorath SISheogorath added auth provider database/sequelize Somehow this is related to the database or ORM docs Releated to new or missing documentation feature Wants to add a new feature Hacktoberfest labels Oct 30, 2017
@SISheogorath SISheogorath added this to the Next release milestone Oct 30, 2017
@DoubleMalt DoubleMalt force-pushed the feature/MattermostAuth branch from 20b3562 to 540ebb1 Compare October 30, 2017 16:47
@DoubleMalt
Copy link
Contributor Author

Done.

@SISheogorath
Copy link
Contributor

SISheogorath commented Oct 30, 2017

Could you squash the commits using git rebase -i HEAD~6 so we don't have to many "Fix" commits in our git history?

Also one important question: Is this new auth provider tested? Because I'm not really sure how to test it since I don't run a mattermost instance myself.

Oh and please since the contributor license agreement #578 because we'll change the license soon to AGPL.

@SISheogorath SISheogorath removed the database/sequelize Somehow this is related to the database or ORM label Oct 31, 2017
@DoubleMalt DoubleMalt force-pushed the feature/MattermostAuth branch from 540ebb1 to 5cda550 Compare October 31, 2017 09:35
@DoubleMalt
Copy link
Contributor Author

Squashed.

The new authentication mechanism is used at the moment for https://notes.doublemalt.net. I can create a test team there so someone can test it against it if desired.

Agreed to the license change.

@SISheogorath
Copy link
Contributor

When you run it (in production), that's fine for me 😄

Only want to prevent untested code.

We have to keep an eye on FortAwesome/Font-Awesome#9727

Currently, there is no mattermost icon :/

But a missing icon will not prevent us from having this awesome feature!

Thanks a lot!

@SISheogorath SISheogorath merged commit 16b3e01 into hackmdio:master Oct 31, 2017
@DoubleMalt DoubleMalt deleted the feature/MattermostAuth branch October 31, 2017 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auth provider docs Releated to new or missing documentation feature Wants to add a new feature Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants