Fix ldap provider name in template#704
Merged
SISheogorath merged 1 commit intohackmdio:masterfrom Jan 29, 2018
SISheogorath:fix/ldapProviderName
Merged
Fix ldap provider name in template#704SISheogorath merged 1 commit intohackmdio:masterfrom SISheogorath:fix/ldapProviderName
SISheogorath merged 1 commit intohackmdio:masterfrom
SISheogorath:fix/ldapProviderName
Conversation
Before this fix it's impossible to set the provider name in the sign-model since `ldap` is a boolean there and this way not able to have an attribute like `ldap.providerName`. Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix it's impossible to set the provider name in the
sign-model since
ldapis a boolean there and this way not ableto have an attribute like
ldap.providerName.