Fix to use url-safe base64 in note url#743
Merged
SISheogorath merged 9 commits intomasterfrom Mar 18, 2018
Merged
Conversation
Signed-off-by: Max Wu <jackymaxj@gmail.com>
Signed-off-by: Max Wu <jackymaxj@gmail.com>
jackycute
changed the title
SISheogorath
approved these changes
Feb 26, 2018
Contributor
SISheogorath
left a comment
SISheogorath
left a comment
There was a problem hiding this comment.
LGTM. Old links still work, new link style is generated.
Probably needs some further testing, but this can probably done in release.
Signed-off-by: Max Wu <jackymaxj@gmail.com>
Member
Author
|
@DenisValeev Please check the latest commit in this PR. |
|
Perfect |
Signed-off-by: Max Wu <jackymaxj@gmail.com>
jackycute
force-pushed
the
fix-to-use-url-safe-base64
branch
from
c2f4c67 to
d08c952
Compare
SISheogorath
reviewed
Mar 3, 2018
| notehistory[i].id = encodeNoteId(id) | ||
| } | ||
| } catch (err) { | ||
| // na |
Contributor
There was a problem hiding this comment.
Mhm, maybe at least some logging would be nice.
jackycute
force-pushed
the
fix-to-use-url-safe-base64
branch
2 times, most recently
from
9cc724a to
d08c952
Compare
Signed-off-by: Max Wu <jackymaxj@gmail.com>
that LZString note url could be parsed by base64url note url and thus return wrong note id Signed-off-by: Max Wu <jackymaxj@gmail.com>
Signed-off-by: Max Wu <jackymaxj@gmail.com>
Member
Author
Signed-off-by: Max Wu <jackymaxj@gmail.com>
Contributor
|
@jackycute do you think it's safe to merge? Or does it need further testing? |
Member
Author
|
It's good for now 👍 |
Contributor
|
Thanks a lot for your work @jackycute! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #742