Add config option for report URI in CSP#761
Merged
SISheogorath merged 1 commit intohackmdio:masterfrom Mar 14, 2018
SISheogorath:feature/reportURI
Merged
Add config option for report URI in CSP#761SISheogorath merged 1 commit intohackmdio:masterfrom SISheogorath:feature/reportURI
SISheogorath merged 1 commit intohackmdio:masterfrom
SISheogorath:feature/reportURI
Conversation
literalplus
approved these changes
Mar 14, 2018
Contributor
literalplus
left a comment
literalplus
left a comment
There was a problem hiding this comment.
Looks good to me from a code perspective (without testing)
|
|
||
| function addReportURI (directives) { | ||
| if (config.csp.reportURI) { | ||
| directives.reportURI = config.csp.reportURI |
Contributor
There was a problem hiding this comment.
Does this work? The docs have reportUri and fields are case-sensitive, right?
I think it would make sense to use reportUri for the config option as well, for consistency with their format – that way we can't have confusions with their documentation.
Contributor
Author
There was a problem hiding this comment.
Agreed. But yes, it worked ^^
This option is needed as it's currently not possible to add an report URI by the directives array. This option also allows to get CSP reports not only on docker based setup but also on our heroku instances. Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option is needed as it's currently not possible to add an report
URI by the directives array. This option also allows to get CSP reports
not only on docker based setup but also on our heroku instances.
Improves CSP support #594