Fix minio port been NaN while HMD_MINIO_PORT isn't set in ENV #767#768
Closed
vazontang wants to merge 1 commit intohackmdio:masterfrom
Closed
Fix minio port been NaN while HMD_MINIO_PORT isn't set in ENV #767#768vazontang wants to merge 1 commit intohackmdio:masterfrom
vazontang wants to merge 1 commit intohackmdio:masterfrom
Conversation
hackmdio#767 Value of minio port should be undefined when HMD_MINIO_PORT isn't set in ENV to prevent original value be overwrote . Signed-off-by: Tang TsungYi <vazontang@gmail.com>
Contributor
|
I'm sorry for jumping in here, but as it actually annoyed me how the last PR broke stuff, I decided to fix it myself in a clean way. See #769 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #767
port: parseInt(process.env.HMD_MINIO_PORT)will makeconfig.minio.portbe NaN whileHMD_MINIO_PORThasn't set in ENV . And It brings on that port value inconfig.jsondoesn't work becauselodash.mergeonly skip undefined value .Therefore , value of minio port should be undefined when
HMD_MINIO_PORTisn't set to prevent original value be overwrote with NaN .