403: Redirect user to login page if not logged in#785
Merged
SISheogorath merged 1 commit intohackmdio:masterfrom May 31, 2018
Merged
403: Redirect user to login page if not logged in#785SISheogorath merged 1 commit intohackmdio:masterfrom
SISheogorath merged 1 commit intohackmdio:masterfrom
Conversation
SISheogorath
added
enhancement
pferreir
force-pushed
the
redirect-to-login
branch
from
21d9197 to
678b57d
Compare
ccoenen
reviewed
Mar 26, 2018
| if (req.user) { | ||
| responseError(res, '403', 'Forbidden', 'oh no.') | ||
| } else { | ||
| req.flash('error', 'You are not allowed to access this note. Maybe try logging in?') |
Contributor
There was a problem hiding this comment.
minor nitpick: this might also apply to other pages. Maybe a more general "you are not allowed to access this page" would be alright.
Signed-Off-By: Pedro Ferreira <pedro.ferreira@cern.ch>
pferreir
force-pushed
the
redirect-to-login
branch
from
678b57d to
99abac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's slightly annoying and confusing that I get a 403 error page for a note I can't access, even if I'm not logged in. A common solution in other apps seems to be redirecting the user to the login page. Since there doesn't seem to be a URL I can send the user to in this case, I redirect them to the home page and flash a message asking them to log in.