Add check for noteId length#797
Merged
SISheogorath merged 1 commit intohackmdio:masterfrom Apr 11, 2018
SISheogorath:fix/LZErrorLog
Merged
Add check for noteId length#797SISheogorath merged 1 commit intohackmdio:masterfrom SISheogorath:fix/LZErrorLog
SISheogorath merged 1 commit intohackmdio:masterfrom
SISheogorath:fix/LZErrorLog
Conversation
jackycute
reviewed
Apr 10, 2018
| }, | ||
| // parse note id by LZString is deprecated, here for compability | ||
| parseNoteIdByLZString: function (_callback) { | ||
| // Calculate mainimal string length for an UUID that is encoded |
Member
There was a problem hiding this comment.
typo here I think?
mainimal -> minimal
Contributor
Author
There was a problem hiding this comment.
Fixed. Thanks :)
As we know the length of an UUID we can check if the base64 string of the provided UUID is long enough for a legacy base64 encoded nodeId and stop processing it in legacy mode, if it's not the case. This should make the ugly warning way less common. Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we know the length of an UUID we can check if the base64 string
of the provided UUID is long enough for a legacy base64 encoded
nodeId and stop processing it in legacy mode, if it's not the case.
This should make the ugly warning way less common.
/cc @dekonnection