Skip to content

Update supported node.js version#994

Merged
SISheogorath merged 1 commit intohackmdio:masterfrom
xf-:patch-1
Oct 7, 2018
Merged

Update supported node.js version#994
SISheogorath merged 1 commit intohackmdio:masterfrom
xf-:patch-1

Conversation

@xf-
Copy link
Copy Markdown
Contributor

@xf- xf- commented Oct 6, 2018

Support includes v9.x, but no v10.x

Console message:

error CodiMD@1.2.1: The engine "node" is incompatible with this module. Expected version ">=6.x <10.x". Got "10.11.0"

https://github.com/nodejs/Release
Node.js LTS 10.x starts in October and i saw no PR to change compatible version

@SISheogorath
Copy link
Copy Markdown
Contributor

We explicitly set the version <10 because version 10 broke scrypt (and iirc also uws which is replaced now).

Since scrypt didn't get an update since 2 years, I don't expect that to be fixed magically, when node didn't suddenly decide to revert their API changes.

@xf-
Copy link
Copy Markdown
Contributor Author

xf- commented Oct 6, 2018

i added it only max to the min Nodejs information in README - no code.
Avoiding next time to install v10 and stick with v8 or v9.

A fork provides v10 support (most active one)
https://github.com/ml1nk/node-scrypt
https://www.npmjs.com/package/@mlink/scrypt

@SISheogorath
Copy link
Copy Markdown
Contributor

Oh just saw that you edit the readme, thought you edit the package.json.

We are aware of node-scrypt. It just needed some work (which now waits for a PR) because node-scrypt and the scrypt package we used, are not compatible in their output formats.


Apart from that, please fix the DCO and we can merge your PR :)

@xf-
Copy link
Copy Markdown
Contributor Author

xf- commented Oct 7, 2018

ok - i just patched it via web edit foo

Support includes v9.x, but no v10.x

Signed-off-by: Xaver Maierhofer <xaver.maierhofer@xwissen.info>
@ccoenen
Copy link
Copy Markdown
Contributor

ccoenen commented Oct 7, 2018

I started replacing scrypt, but most alternatives can't be synchronous, and the place where it's used needs it to be synchronous (limitation of Sequelize).
ccoenen@2c84b51

with node10 this wouldn't be a problem, AFAIK it has a sync version of scrypt.

@SISheogorath SISheogorath merged commit 616dfdf into hackmdio:master Oct 7, 2018
@SISheogorath SISheogorath added the docs Releated to new or missing documentation label Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Releated to new or missing documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants