Skip to content

HCK-7311: http requester - #49

Merged
chulanovskyi-bs merged 22 commits into
developfrom
feat/HCK-7311-http-requester
Aug 30, 2024
Merged

HCK-7311: http requester#49
chulanovskyi-bs merged 22 commits into
developfrom
feat/HCK-7311-http-requester

Conversation

@chulanovskyi-bs

@chulanovskyi-bs chulanovskyi-bs commented Aug 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
Sub-taskHCK-7311 [FIX.PARTIAL][Glue] Not working with custom proxy: Configure the AWS SDK to use Fetch

Technical details

  • a dedicated request handler for Glue Client that use net.fetch explicitly in FE / RE processes.
  • removed SSL manual configuration from the connection settings. We can do it safely, because even given the fact it was involved in the codebase - it has never been used in the end by the requester

bigorn0
bigorn0 reviewed Aug 30, 2024
View reviewed changes
Comment thread forward_engineering/api.js Outdated
VitaliiBedletskyi
VitaliiBedletskyi reviewed Aug 30, 2024
View reviewed changes
Comment thread reverse_engineering/api.js Outdated
@chulanovskyi-bs

chulanovskyi-bs commented Aug 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Tests are all green

bigorn0
bigorn0 reviewed Aug 30, 2024
View reviewed changes
Comment thread esbuild.package.js
bigorn0
bigorn0 reviewed Aug 30, 2024
View reviewed changes
Comment thread reverse_engineering/commandsService.js
bigorn0
bigorn0 reviewed Aug 30, 2024
View reviewed changes

@bigorn0 bigorn0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial small non blocking remarks, i'll dig further.

Comment thread shared/httpHandler/httpHandler.js Outdated
Comment thread shared/httpHandler/httpHandler.js Outdated
Comment thread shared/httpHandler/requestTimeout.js Outdated
Comment thread shared/httpHandler/queryBuilder.js Outdated
thomas-jakemeyn
thomas-jakemeyn approved these changes Aug 30, 2024
View reviewed changes

@thomas-jakemeyn thomas-jakemeyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aligned with the improvements suggested by @bigorn0 but I did not see anything that would block this PR from being merged.

@chulanovskyi-bs
chulanovskyi-bs added this pull request to the merge queue Aug 30, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 30, 2024
@chulanovskyi-bs
chulanovskyi-bs added this pull request to the merge queue Aug 30, 2024
@sonarqubecloud

sonarqubecloud Bot commented Aug 30, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Merged via the queue into develop with commit f70c1a2 Aug 30, 2024
@chulanovskyi-bs
chulanovskyi-bs deleted the feat/HCK-7311-http-requester branch August 30, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomas-jakemeyn thomas-jakemeyn thomas-jakemeyn approved these changes
@bigorn0 bigorn0 bigorn0 approved these changes
@VitaliiBedletskyi VitaliiBedletskyi VitaliiBedletskyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chulanovskyi-bs @thomas-jakemeyn @bigorn0 @VitaliiBedletskyi