Skip to content

Adds new integration [ha-china/cn_im_hub]#6969

Merged
frenck merged 9 commits into
hacs:masterfrom
Desmond-Dong:cn_im_hub
Jun 22, 2026
Merged

Adds new integration [ha-china/cn_im_hub]#6969
frenck merged 9 commits into
hacs:masterfrom
Desmond-Dong:cn_im_hub

Conversation

@Desmond-Dong

Copy link
Copy Markdown
Contributor

Checklist

  • I've read the publishing documentation.
  • I've added the HACS action to my repository.
  • (For integrations only) I've added the hassfest action to my repository.
  • The actions are passing without any disabled checks in my repository.
  • I've added a link to the action run on my repository below in the links section.
  • I've created a new release of the repository after the validation actions were run successfully.

Links

Link to current release: https://github.com/ha-china/cn_im_hub/releases/tag/v2026.04.3
Link to successful HACS action (without the ignore key): https://github.com/ha-china/cn_im_hub/actions/runs/24172924836
Link to successful hassfest action (if integration): https://github.com/ha-china/cn_im_hub/actions/runs/24172924845

@hacs-bot

hacs-bot Bot commented Apr 13, 2026

Copy link
Copy Markdown

Thank you for submitting your repository to HACS (Home Assistant Community Store).

Your submission is in the review queue:
Your repository is waiting to be reviewed and included in HACS.

You can view the current queue here. Pull requests are processed in the order they were created, oldest first.

What to avoid during review:
To help reviewers work efficiently, don't do the following:

  • Comment on the pull request - The reviewer will contact you when they have feedback or questions.
  • Open a new pull request - This won't speed up the process and creates duplicate work.
  • Ask followers to comment on the pull request - This won't speed up the process and may delay your review.
  • Merge in the default branch - Only do this if a maintainer asks you to resolve a merge conflict.

If you need to make changes:
You can continue updating your repository while waiting for review. Changes to your repository will be reflected when the reviewer examines it. Only comment on the pull request if you need to withdraw your submission or have critical information for reviewers.

About draft pull requests:
Draft pull requests aren't included in the review queue. Your pull request may be marked as draft by a reviewer if issues need to be addressed. Once you've resolved all issues, mark it as ready for review to re-enter the queue.

What happens next:
Once a reviewer examines your submission, they'll either:

  • Approve and merge your pull request if everything meets the requirements
  • Request changes or ask questions if adjustments are needed

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Desmond-Dong, thanks for the submission! 👋

A couple of items before this can be added to the default catalog:

  1. The integration registers FeishuCardCallbackView as an HTTP endpoint with requires_auth = False at /api/cn_im_hub/feishu/card_callback, protected only by a soft token check, and it dispatches events onto the Home Assistant event bus from that handler. An unauthenticated public endpoint that can inject events is a security concern: anyone who can reach the HA instance could fire those events. Please verify Feishu callbacks cryptographically (the official request signature / encrypt-key + verification-token scheme) and reject anything that doesn't validate, rather than relying on requires_auth = False plus a plain token.
  2. The repository needs a LICENSE file (or LICENSE.md) at its root (https://hacs.xyz/docs/publish/start). I don't see one on main/master. Please add one and cut a new release that includes it.

Once those are addressed, push and re-request review.

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@hacs-bot hacs-bot Bot marked this pull request as draft June 20, 2026 17:35
Desmond-Dong added a commit to ha-china/cn_im_hub that referenced this pull request Jun 21, 2026
Requested by HACS review:\nhttps://github.com/hacs/default/pull/6969#pullrequestreview-4538447792
@Desmond-Dong Desmond-Dong marked this pull request as ready for review June 21, 2026 03:46

@hacs-bot hacs-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your branch seems out of date. Please update your branch with the latest changes from the base branch.

@hacs-bot hacs-bot Bot marked this pull request as draft June 21, 2026 03:46
@Desmond-Dong Desmond-Dong requested a review from frenck June 21, 2026 03:56
@Desmond-Dong

Copy link
Copy Markdown
Contributor Author

Hi @Desmond-Dong, thanks for the submission! 👋

A couple of items before this can be added to the default catalog:

  1. The integration registers FeishuCardCallbackView as an HTTP endpoint with requires_auth = False at /api/cn_im_hub/feishu/card_callback, protected only by a soft token check, and it dispatches events onto the Home Assistant event bus from that handler. An unauthenticated public endpoint that can inject events is a security concern: anyone who can reach the HA instance could fire those events. Please verify Feishu callbacks cryptographically (the official request signature / encrypt-key + verification-token scheme) and reject anything that doesn't validate, rather than relying on requires_auth = False plus a plain token.
  2. The repository needs a LICENSE file (or LICENSE.md) at its root (https://hacs.xyz/docs/publish/start). I don't see one on main/master. Please add one and cut a new release that includes it.

Once those are addressed, push and re-request review.

../Frenck

                       

Blogging my personal ramblings at frenck.dev

Dear @frenck Thank you for your help. Since FeiShu Cards are beyond instant messaging scope, I have removed this .

@Desmond-Dong Desmond-Dong marked this pull request as ready for review June 21, 2026 14:42

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Desmond-Dong, thanks for cutting the v2026.06.2 release addressing the earlier review. 👋

Approving and merging now.

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck merged commit c9f20cf into hacs:master Jun 22, 2026
12 checks passed
@hacs-bot

hacs-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

Congratulations! Your repository has been added to HACS 🎉

Your repository has been approved:
Your repository has been successfully merged into the HACS default repository list.
It might take up to 8 hours before your repository appears in HACS for users.

Resources:

Thank you for contributing to the Home Assistant community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants