Adds new integration [ha-china/cn_im_hub]#6969
Conversation
|
Thank you for submitting your repository to HACS (Home Assistant Community Store). Your submission is in the review queue: You can view the current queue here. Pull requests are processed in the order they were created, oldest first. What to avoid during review:
If you need to make changes: About draft pull requests: What happens next:
|
frenck
left a comment
There was a problem hiding this comment.
Hi @Desmond-Dong, thanks for the submission! 👋
A couple of items before this can be added to the default catalog:
- The integration registers
FeishuCardCallbackViewas an HTTP endpoint withrequires_auth = Falseat/api/cn_im_hub/feishu/card_callback, protected only by a soft token check, and it dispatches events onto the Home Assistant event bus from that handler. An unauthenticated public endpoint that can inject events is a security concern: anyone who can reach the HA instance could fire those events. Please verify Feishu callbacks cryptographically (the official request signature / encrypt-key + verification-token scheme) and reject anything that doesn't validate, rather than relying onrequires_auth = Falseplus a plain token. - The repository needs a
LICENSEfile (orLICENSE.md) at its root (https://hacs.xyz/docs/publish/start). I don't see one onmain/master. Please add one and cut a new release that includes it.
Once those are addressed, push and re-request review.
../Frenck
Blogging my personal ramblings at frenck.devRequested by HACS review:\nhttps://github.com/hacs/default/pull/6969#pullrequestreview-4538447792
Dear @frenck Thank you for your help. Since FeiShu Cards are beyond instant messaging scope, I have removed this . |
frenck
left a comment
There was a problem hiding this comment.
Hi @Desmond-Dong, thanks for cutting the v2026.06.2 release addressing the earlier review. 👋
Approving and merging now.
../Frenck
Blogging my personal ramblings at frenck.dev|
Congratulations! Your repository has been added to HACS 🎉 Your repository has been approved: Resources: Thank you for contributing to the Home Assistant community! 🎉 |
Checklist
Links
Link to current release: https://github.com/ha-china/cn_im_hub/releases/tag/v2026.04.3
Link to successful HACS action (without the
ignorekey): https://github.com/ha-china/cn_im_hub/actions/runs/24172924836Link to successful hassfest action (if integration): https://github.com/ha-china/cn_im_hub/actions/runs/24172924845