use commits from haddock3 repo as version#8
Merged
rvhonorato merged 1 commit intoJul 17, 2026
Conversation
rvhonorato
deleted the
7-allow-pulling-an-unreleased-haddock3-versioncommit
branch
July 17, 2026 08:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as mentioned here: #5 (comment), there is an use-case in which people might want to use the benchmarking pipeline on a version of haddock3 that has not yet been published to pypi.
this PR adds the possibility of pulling either a version from pypi OR a commit hash from the repository:
Important
Note that I deliberately set it as needing to take a commit from the remote, not local. This is so that we can keep some reproducibility even for unreleased sources - if someone is using a commit hash from their local copy, there is no way someone else can reproduce it. If its a commit hash from the remote, even if it never gets pushed into the main branch, it will remain on the repository history and can thus be reproduced. But keep in mind that over time the commits might not be accessible, so PREFER using pypi versions.