COYOFOUR-26737 cat-select show tooltip for labels#1007
Merged
ianovalena merged 6 commits intoJun 25, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Adds tooltip support for truncated labels in cat-select by extending cat-tooltip with a configurable trigger mode and wiring truncation detection into the select UI.
Changes:
- Add
triggerprop tocat-tooltipto control whether it responds to hover, focus, or both. - Wrap
cat-selectoption labels, pills, and single-select input withcat-tooltip, enabling tooltips only when text is detected as truncated. - Add/update unit tests and framework/type artifacts (Stencil typings, Angular proxies, README dependency graphs).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/components/cat-tooltip/readme.md | Document new trigger prop and dependency graph. |
| core/src/components/cat-tooltip/cat-tooltip.tsx | Introduce trigger prop and conditional listener wiring. |
| core/src/components/cat-tooltip/cat-tooltip.spec.tsx | Add tests for trigger behavior; mock floating-ui. |
| core/src/components/cat-select/readme.md | Update dependency list/graph to include cat-tooltip. |
| core/src/components/cat-select/cat-select.tsx | Add truncation detection + wrap labels/input/pills in tooltips. |
| core/src/components/cat-select/cat-select.spec.tsx | Add truncation-related unit tests. |
| core/src/components/cat-select-demo/readme.md | Update graph to reflect cat-tooltip usage. |
| core/src/components.d.ts | Generated typings updated for new trigger prop. |
| angular/projects/catalyst/src/lib/directives/proxies.ts | Expose new trigger input in Angular proxy for cat-tooltip. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
glushkova91
reviewed
Jun 25, 2026
glushkova91
previously approved these changes
Jun 25, 2026
glushkova91
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.