Skip to content

Conversation

@hakril
Copy link
Owner

@hakril hakril commented May 28, 2024

Looks like QueryDosDevice can return multiple path if DefineDosDevice was called before.
This was an error case in LogicalDrive.path but not anymore as it's a valid return value of the API.

LogicalDrive.path return the first path (The current valid one) & LogicalDrive.query_dos_device() return the full list (the historic)

@github-actions
Copy link

github-actions bot commented May 28, 2024

Unit Test Results

430 tests  ±0   402 ✔️ ±0   2m 46s ⏱️ -1s
    1 suites ±0     28 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit f957c64. ± Comparison against base commit 328735b.

This pull request removes 38 and adds 38 tests. Note that renamed tests count towards both.
test_object_manager ‑ test_directory_object[\\KnownDLLs]
test_object_manager ‑ test_multiple_access_type[\\KnownDLLs]
test_registry ‑ test_registry_badly_encoded_values[Hello\x00World\x00This is not really unicode\x00\x00-7]
test_registry ‑ test_registry_badly_encoded_values[Hello\x00World\x00This is not unicode\x00\x00-7]
test_registry ‑ test_registry_badly_encoded_values[\xff\xd8-7]
test_registry ‑ test_registry_set_get_simple_values_with_types[-0]
test_registry ‑ test_registry_set_get_simple_values_with_types[-1]
test_registry ‑ test_registry_set_get_simple_values_with_types[1234605616436508552-11]
test_registry ‑ test_registry_set_get_simple_values_with_types[287454020-4]
test_registry ‑ test_registry_set_get_simple_values_with_types[287454020-5]
…
test_object_manager ‑ test_directory_object[\KnownDLLs]
test_object_manager ‑ test_multiple_access_type[\KnownDLLs]
test_registry ‑ test_registry_badly_encoded_values[Hello\x00World\x00This is not really unicode\x00\x00-type2]
test_registry ‑ test_registry_badly_encoded_values[Hello\x00World\x00This is not unicode\x00\x00-type1]
test_registry ‑ test_registry_badly_encoded_values[\xff\xd8-type0]
test_registry ‑ test_registry_set_get_simple_values_with_types[-type3]
test_registry ‑ test_registry_set_get_simple_values_with_types[-type9]
test_registry ‑ test_registry_set_get_simple_values_with_types[287454020-type0]
test_registry ‑ test_registry_set_get_simple_values_with_types[287454020-type1]
test_registry ‑ test_registry_set_get_simple_values_with_types[BIN_DATA\x01\x02\x03\x00\x00\x01\x02\x03\x04\x05\x06\x07\x08\t\n\x0b\x0c\r\x0e\x0f\x10\x11\x12\x13\x14\x15\x16\x17\x18\x19\x1a\x1b\x1c\x1d\x1e\x1f !"#$%&\'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~\x7f\x80\x81\x82\x83\x84\x85\x86\x87\x88\x89\x8a\x8b\x8c\x8d\x8e\x8f\x90\x91\x92\x93\x94\x95\x96\x97\x98\x99\x9a\x9b\x9c\x9d\x9e\x9f\xa0\xa1\xa2\xa3\xa4\xa5\xa6\xa7\xa8\xa9\xaa\xab\xac\xad\xae\xaf\xb0\xb1\xb2\xb3\xb4\xb5\xb6\xb7\xb8\xb9\xba\xbb\xbc\xbd\xbe\xbf\xc0\xc1\xc2\xc3\xc4\xc5\xc6\xc7\xc8\xc9\xca\xcb\xcc\xcd\xce\xcf\xd0\xd1\xd2\xd3\xd4\xd5\xd6\xd7\xd8\xd9\xda\xdb\xdc\xdd\xde\xdf\xe0\xe1\xe2\xe3\xe4\xe5\xe6\xe7\xe8\xe9\xea\xeb\xec\xed\xee\xef\xf0\xf1\xf2\xf3\xf4\xf5\xf6\xf7\xf8\xf9\xfa\xfb\xfc\xfd\xfe\xff-type7]
…

♻️ This comment has been updated with latest results.

@hakril hakril merged commit ee409e4 into master May 30, 2024
@hakril hakril deleted the volume_dospath_fix branch June 14, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants