Skip to content

Change LogicalDrive.path logic based on QueryDosDevice returned valudes #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024
Merged

Change LogicalDrive.path logic based on QueryDosDevice returned valudes #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions windows/winobject/volume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,16 @@ def path(self):
"""The target path of the device

:type: :class:`str`"""
res = query_dos_device(self.name.strip("\\"))
if len(res) != 1:
raise ValueError("[Unexpected result] query_dos_device(logicaldrive) returned multiple path")
return res[0]
# QueryDosDevice can returns multiple path if DefineDosDevice(AW) was used before
# Looks like its per-process
# But in ths cas the first entry is the effective-one and the others are the previous entries
# https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-querydosdevicea
# The first null-terminated string stored into the buffer is the current mapping for the device. The other null-terminated strings represent undeleted prior mappings for the device.
return query_dos_device(self.name.strip("\\"))[0]

@property
def query_dos_device(self):
return query_dos_device(self.name.strip("\\"))

def query_info(self, info):
return windows.utils.query_volume_information(self.handle, info)
Expand Down