Skip to content

[Hexagon] Fix compilation failures hexagon_remote#7601

Merged
steven-johnson merged 1 commit into
halide:mainfrom
aankit-ca:compile_hexagon_remote
Jun 1, 2023
Merged

[Hexagon] Fix compilation failures hexagon_remote#7601
steven-johnson merged 1 commit into
halide:mainfrom
aankit-ca:compile_hexagon_remote

Conversation

@aankit-ca

Copy link
Copy Markdown

Fix for:

  1. Missing include directory for pthread.h
  2. Incorrect function signature for qurt_hvx_lock

Fix for:
1. Include directory for pthread.h
2. Function signature for qurt_hvx_lock
@aankit-ca

Copy link
Copy Markdown
Author

@steven-johnson
steven-johnson merged commit bd33a62 into halide:main Jun 1, 2023
@steven-johnson

Copy link
Copy Markdown
Contributor

Pulling this into google3, it fails to build because known_symbols.cpp doesn't include qurt_hvx.h, which is needed for qurt_hvx_mode_t to be declared. If I add #include "qurt_hvx.h", it then fails to compile because the declarations in that header file aren't marked as extern "C".

How did you test this? Apparently we don't usually rebuild this file as part of our buildbots.

@steven-johnson

Copy link
Copy Markdown
Contributor

...also, when I try to build locally, I fail for unrelated reasons:

# Hexagon SDK 4.3.0 is locally installed
$ export SDK_ROOT=$HOME/Qualcomm
$ export HEXAGON_SDK_ROOT=${SDK_ROOT}/Hexagon_SDK/4.3.0
$ export HEXAGON_TOOLS_ROOT=${HEXAGON_SDK_ROOT}/tools/HEXAGON_Tools/8.4.11
$ cd src/runtime/hexagon_remote
$ make all
/bin/sh: line 1: /usr/local/google/home/srj/Qualcomm/Hexagon_SDK/4.3.0/tools/android-ndk-r19c/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++: No such file or directory

steven-johnson added a commit that referenced this pull request Jun 5, 2023
steven-johnson added a commit that referenced this pull request Jun 5, 2023
Revert "[Hexagon] Fix compilation failures hexagon_remote (#7601)"

This reverts commit bd33a62.
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
Fix for:
1. Include directory for pthread.h
2. Function signature for qurt_hvx_lock

Co-authored-by: Ankit Aggarwal <aankit@quicinc.com>
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
Revert "[Hexagon] Fix compilation failures hexagon_remote (halide#7601)"

This reverts commit bd33a62.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants