Add FuncVec convenience type - #9419
Merged
Merged
Conversation
abadams
approved these changes
Sep 1, 2026
alexreinking
force-pushed
the
alexreinking/funcvecs
branch
from
September 1, 2026 19:06
446f6c7 to
946669d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9419 +/- ##
==========================================
- Coverage 70.02% 69.92% -0.10%
==========================================
Files 261 261
Lines 79393 79405 +12
Branches 19359 19362 +3
==========================================
- Hits 55593 55526 -67
- Misses 17915 17940 +25
- Partials 5885 5939 +54 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alexreinking
force-pushed
the
alexreinking/funcvecs
branch
from
September 3, 2026 17:10
946669d to
8d5ef1b
Compare
Defaults to empty, so it's appended after the base name (and index, for non-singleton vectors) without changing existing call sites.
Use concat_strings instead of chained operator+ to avoid unnecessary temporary string allocations. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
alexreinking
force-pushed
the
alexreinking/funcvecs
branch
from
September 4, 2026 09:08
8d5ef1b to
a54ad28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #9387, which was auto-closed as a no-op merge into
alexreinking/rfactor-hoistingwhile the stack was being reordered (funcvecs moved to the bottom of the stack, below rfactor-hoisting). Added a name suffix relative to #9387 — see that PR for prior review history.