Skip to content

Revert "verify serialized buffer before accessing it in the deserializer" - #9426

Merged
alexreinking merged 1 commit into
mainfrom
revert-9395-verify-serialized-buffer
Sep 4, 2026
Merged

Revert "verify serialized buffer before accessing it in the deserializer"#9426
alexreinking merged 1 commit into
mainfrom
revert-9395-verify-serialized-buffer

Conversation

@abadams

@abadams abadams commented Sep 3, 2026

Copy link
Copy Markdown
Member

Reverts #9395

Unfortunately the original PR didn't run on the one bot that tests serialization, and our round-trip testing shows that in a bunch of cases our flatbuffers fail to verify. This is obviously not a good thing, but we should temporarily revert this while figuring it out in order to keep CI green.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.12%. Comparing base (14144bf) to head (b6d10de).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9426      +/-   ##
==========================================
- Coverage   70.19%   70.12%   -0.07%     
==========================================
  Files         261      261              
  Lines       79399    79393       -6     
  Branches    19361    19359       -2     
==========================================
- Hits        55732    55677      -55     
+ Misses      17886    17880       -6     
- Partials     5781     5836      +55     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexreinking
alexreinking merged commit 0537858 into main Sep 4, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants