Skip to content

Use S3Client instead of S3AsyncClient to avoid waiting two seconds for closing - #30

Merged
f2c-ci-robot[bot] merged 1 commit into
halo-dev:mainfrom
JohnNiang:refactor/use-s3client
Apr 6, 2023
Merged

Use S3Client instead of S3AsyncClient to avoid waiting two seconds for closing #30
f2c-ci-robot[bot] merged 1 commit into
halo-dev:mainfrom
JohnNiang:refactor/use-s3client

Conversation

@JohnNiang

Copy link
Copy Markdown
Member

Fixes #23

修复文件上传慢的问题

Signed-off-by: John Niang <johnniang@fastmail.com>
@f2c-ci-robot f2c-ci-robot Bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 1, 2023
@f2c-ci-robot
f2c-ci-robot Bot requested review from longjuan and minliacom April 1, 2023 09:28
@JohnNiang

Copy link
Copy Markdown
Member Author

/ping @longjuan

@longjuan longjuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
/lgtm

@f2c-ci-robot f2c-ci-robot Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023

@ruibaby ruibaby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot

f2c-ci-robot Bot commented Apr 6, 2023

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023
@f2c-ci-robot
f2c-ci-robot Bot merged commit 5e9b9f8 into halo-dev:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

上传文件慢

3 participants