Fix utility robustness - #16
Merged
Merged
Conversation
The rate/parallel setup used two syscalls without checking for failure: - The shared sem_t and counter pages from mmap() were used directly; on MAP_FAILED the following sem_init()/*counter access would dereference (void*)-1 and crash. Bail out with an error instead. - fork() was assumed to succeed; on -1 the worker was silently lost. Report the failure to stderr. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The SIGINT handler was named abort(int), colliding with the standard library's abort(void) declared via <stdlib.h>. It compiled only because the signatures differ, but the clash is fragile and confusing. Rename it to sigint_handler; behavior is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mmap()andfork()return valuesabort()