Skip to content

initial commit#1

Open
hamidoudiallo96 wants to merge 4 commits into
masterfrom
hamidou-diallo
Open

initial commit#1
hamidoudiallo96 wants to merge 4 commits into
masterfrom
hamidou-diallo

Conversation

@hamidoudiallo96

Copy link
Copy Markdown
Owner

No description provided.

@seanwu20-zz seanwu20-zz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on MVP! A lot of array methods like map and filter already create a new array, so there's no need to make a separate array.

let allCaps = [];
const new_first = runners.map(function(char){
allCaps.push(char.first_name.toUpperCase())
});
This can be simplified to
const new_first = runners.map(function(char){
char.first_name.toUpperCase())
});

I'd also look into a adding a gitignore file so GitHub doesn't upload your VS Code folder and .idea folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants