Replace exits with throws in commands - #379
Merged
Merged
Conversation
Contributor
|
ℹ️ Optional job failed: Ruby jruby |
Commands calling `exit` directly cause instability in test runs, which also exit early. This leads to false positives. There was a mechanism injecting alternative exit mock, but you had to remember to use it every time. We already fixed all (?) the cases once, but the problem came back.
Member
|
This is a great improvement, thank you @katafrakt! I'm very sorry for the delay in my review, but I think we can merge this now, and because it's an internal change only, release it with the next release. I also took a quick look at the other repos where we add or enhance our CLI commands (like hanami-rspec and hanami-reloader), and it doesn't look like any changes are needed there. |
timriley
approved these changes
Jul 31, 2026
Contributor
Author
|
No worries about the delay. This is just to ensure that we are always running all specs, so we don't have accidental false positives (happened to me in the past). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm seeing test runs ending prematurely again (see #307) locally. This is my attempt to address this problem more systematically, which happened to use the same approach that Tim suggested in the last comment in the other PR.