chore(docs): update versioned docs examples - #279
Merged
Conversation
demtario
added a commit
that referenced
this pull request
Sep 2, 2026
Master's `e2e` job has been red since the 2026-09-01 docs regen (78fe31b, #279) added an `18.1` bucket: two DEMOS-1C assertions hard-coded `available for Handsontable 18.0`, while the app names the highest release bucket in `docs-buckets.json` — now 18.1. Reproduced deterministically on 2472da9 with a clean build, so it is master's breakage, not any PR's. Both assertions now resolve the expected bucket with the same helper the app uses, `highestReleaseBucket`, read over `docs-buckets.json`, so the next regen cannot stale them again. The helper is imported from `packages/runtime/src`, not `dist`: the `e2e` job downloads only the authoring build, and `e2e-live` skips `pnpm build` entirely, so a dist import fails at spec load in both (which is what the first push of this branch proved). Playwright resolves the `.js` specifier to the source, verified with `packages/runtime/dist` moved out of the tree. Still discriminating: suppressing the suggestion half of `docsBucketAbsentMessage` turns both tests red. Verified against a local preview of the built app: the full deterministic suite is 239 passed / 145 skipped / 0 failed (share-view excluded — it self-skips without a deployed API origin, which is also why the `e2e` job never runs it). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by the Import versioned docs examples workflow.
The workflow imported the requested Handsontable documentation bucket(s)
with concrete npm dependency versions.
Note
Low Risk
Generated static assets for documentation previews only; no changes to core product or auth paths.
Overview
Adds or refreshes the 18.1 documentation example catalog under
runner/apps/authoring/public/docs-examples/18.1/as generated JSON bundles (manifest plus per-example payloads) consumed by the authoring app’s docs catalog and live previews.Each artifact pins Handsontable 18.1.0 and embeds runnable sources for multiple stacks—vanilla JS/TS (Sandpack), React, Vue (container), and Angular (container)—for guides such as Accessibility (keyboard/focus option toggles), column menu, and context menu (including custom menu items with a grid-level
sanitizerfor HTML labels). No application runtime code changes; this is static imported content for docs demos.Reviewed by Cursor Bugbot for commit 78fe31b. Bugbot is set up for automated code reviews on this repo. Configure here.