Skip to content

Fix: Anvil Combine Helper bug - #3258

Merged
hannibal002 merged 2 commits into
hannibal002:betafrom
Ownwn:anvil-combine-helper-fix
Jan 22, 2025
Merged

Fix: Anvil Combine Helper bug#3258
hannibal002 merged 2 commits into
hannibal002:betafrom
Ownwn:anvil-combine-helper-fix

Conversation

@Ownwn

@Ownwn Ownwn commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

What

Fix the Anvil Combine Helper not highlighting matching items when the book is in the second anvil slot

Images

OLD

old

NEW

new

Changelog Fixes

  • Fixed Anvil Combine Helper not highlighting when a book is in the second slot. - Ownwn

@github-actions github-actions Bot added Bug Fix Bug fixes Wrong Title/Changelog There is an error in the title or changelog labels Jan 21, 2025
@github-actions

Copy link
Copy Markdown

I have detected some issues with your pull request:

Body issues:
No changes detected in this pull request

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions

Copy link
Copy Markdown

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Fixed Anvil Combine Helper
Change should end with a full stop in text: Now highlights when book is in the second slot too

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions Bot removed the Wrong Title/Changelog There is an error in the title or changelog label Jan 21, 2025
@CalMWolfs CalMWolfs added this to the Version 2.0.0 milestone Jan 21, 2025

@hannibal002 hannibal002 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While looking at this feature I was like "why is the code so bad", then I noticed the changes you did and i was like "ok you repaired it without changing the least amount of code, thats actually impressive" (the feature should cache the slots and should use item ids instead of lore checks)

@hannibal002
hannibal002 merged commit 2c29310 into hannibal002:beta Jan 22, 2025
@github-actions github-actions Bot removed the Bug Fix Bug fixes label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants