feat(ratewise): v2 等值雙列功能補全第二波(E8 wave-B) - #668
Merged
s123104 merged 1 commit intoJul 7, 2026
Conversation
- 換錢所來源切換:rate chip 同列 icon-only 鈕(支援幣別才渲染、零暴露),接上 659 換錢所標籤分支 - 換錢所啟用中 chip tap=回銀行基準(對齊 v1 pill 語意);來源切換取消 pending settle(B2) - 運算式列:keypad 回報表達式,含運算子才顯示於活躍列 absolute overlay,settle/語意變更即隱藏 - overlay 不佔版面高度:三視口零捲動硬約束不回歸(e2e 斷言 scrollHeight 不變) - 趨勢 sheet:內嵌現金/即期基準切換,sheet 專屬序列走 resolveTrendSeries 誠實回落,值-標籤同源 - 趨勢 sheet:seo-paths SSOT 判斷 pair 落地頁存在才顯示「查看幣別攻略」連結,chart 啟用 tooltip 基準標註 - SR 播報(issue 620):settle 事件共用觸發 aria-live=polite 摘要,4 語系、非逐鍵、B1 零值守門共用 測試:ratewise vitest 4948 passed(含 wave-A 守門);converter-v2 e2e 28 passed(desktop+mobile,含 320px 不溢出) Co-authored-by: Cursor <cursoragent@cursor.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
|
✅ SEO 審計通過!所有 2026 標準驗證項目都符合要求。
|
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #620
摘要
依
.claude/prds/converter-v2-completeness-design.md第 3 節裁決 #3/#5/#8/#10,於 v2 等值雙列補全第二波四項能力。未動 #667 wave-A 守門機制(settle/quick chips/翻轉/複製)、#660 pills、#659 basis 同源;#665 card 於 v2 維持禁用(本波不碰 card)。四缺口實作說明
缺口 3:換錢所來源切換
bank ⇄ exchange-shop,44×44 熱區、aria-pressed,與 ⇄ 翻轉鈕同規格exchangeShopCurrency非空(如 TWD↔KRW)才渲染;不支援幣別完全不出現缺口 5:運算式列
ConverterKeypad新增onExpressionChange回報原始表達式;父層判斷「含運算子」才視為計算進行中pointer-events-none、右對齊、超長左緣截尾保最新輸入)——顯示/隱藏零位移(CLS 0),不佔版面高度scrollHeight不變(三視口零捲動硬約束不回歸)缺口 8:趨勢 sheet 強化
SegmentedControl(min/max 同列右側);sheet 專屬useConverterTrend序列走resolveTrendSeries([enhancement] 趨勢圖歷史資料僅現金賣出基準,與卡片所選費率模式不一致 #564)——即期序列不足誠實回落現金且標註同步(值-標籤同源,KRW 情境有單元測試鎖定);換錢所來源時隱藏(無現金/即期語意)seo-paths.tsSSOT(isCurrencyPagePath/isReverseCurrencyPagePath)判斷/{pair}/落地頁存在才渲染「查看 {幣別} 攻略 →」(react-router Link,點擊即關 sheet);不存在(如 USD→JPY)零暴露basisLabel啟用MiniTrendChart既有 crosshair tooltip(日期+數值+基準標註)缺口 10:SR 播報(Closes #620)
aria-live="polite"+role="status"的sr-only摘要區常駐 DOMconverterV2.settleAnnouncement,含插值槽守門測試)文案同步檢查結果
已檢查
seo-metadata(core.ts/currency-landing.ts)與 FAQ/指南文案:快速金額按鈕、換算歷史記錄的描述均為通用陳述,無「僅單幣別傳統模式」「經典模式限定」類限定語(wave-A/B 補齊後描述對 v2 自動成立),故 SSOT 層無需修改。驗收
E8 佈局預算斷言不動全綠;運算式列 overlay 顯示期間scrollHeight不變斷言新增pnpm --filter @app/ratewise exec vitest run:4948 passed(188 檔,含 wave-A 全部守門)截圖矩陣(QA 暫存
screenshots/,依 SOP 不入 commit)wave-b-expression-390.pngwave-b-exchange-shop-390.pngwave-b-trend-sheet-390.pngwave-b-expression-375.pngwave-b-exchange-shop-375.pngwave-b-trend-sheet-375.pngwave-b-expression-320.pngwave-b-exchange-shop-320.pngwave-b-trend-sheet-320.png另有 e2e 證據截圖於
test-results/(v2-e8-expression-row-*、v2-e8-rate-source-320-*、v2-e8-trend-sheet-*)。依據
.claude/prds/converter-v2-completeness-design.md(wave-B 範圍:裁決 chore(ci): 新增 pnpm audit 安全掃描到 CI 流程 #3/fix(ui): UI/UX 無障礙性改善與 Commit 規範建立 #5/fix(ci): 修正 CI 測試指令使用 test:coverage script #8/fix/ci pipeline optimization #10)reward-rw-e8-wave-b-v2-completeness(+1 → 累計 +181)Made with Cursor