docs(starpuff): #906 審查收斂——註解漂移修正、AGENTS.md v5.7 與 002 數字訂正 - #908
Merged
Conversation
- 審查 #906 Grok LOW 根修並全庫掃描:搬走符號的註解/文件不得再指向舊位置 - src 註解 8 處:starburstDirector(seenFlavorHints→sceneEvents)、main.ts 與 stage.ts ×3(syncGateSweep→levelGate.sweep/掃掠基準歸屬)、caramelStatus (sync 呼叫者→damageDirector)、boss.ts/syrona.ts/bossRoom.ts(逐幀委派者 →damageDirector)、stageModel(spawnGate→門生成當幀) - 設計文件 3 處:04-levels-world(spawnGate 措辭、advanceTide 歸屬)、 03-enemies-bosses(getVentLift 委派者);「」引述字串零變更,守門不受影響 測試:vitest 守門子集(design-docs+src/game)1053 案全綠;純註解與文件,零行為改動 Co-authored-by: Cursor <cursoragent@cursor.com>
- 審查 #906 兩席建議經 PM 採納落 SOP:PM 對工人分支 rebase 前必留 pre-rebase ref 供 patch-id 覆核;bot 勝率僅得作觀測不得作裁決真值(同版 main 時段噪訊 11pp 實證), 難度驗收以機械 diff/既有套件/靜態軸與確定性指標為階層 - strangler 拆分建議兩段式 commit(①模組+測試 ②切 wiring)使測試先行在 git 史可證; 不採者 PR 敘事必須改寫為「機械搬移+既有套件佐證」 - 修訂紀錄新增 v5.7 列並同步檔尾版本標記 測試:無(SOP 文件變更) Co-authored-by: Cursor <cursoragent@cursor.com>
- 純文件與註解修正、零行為變更 → patch(沿 #880 docs PR changeset 慣例) 測試:無(changeset 檔案) Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
- 審查 #908 Sonnet LOW:原「×N 取中位」無具體門檻,執行者會各自解讀; 沿 Lighthouse 序列化真值 SSOT 明寫至少 ×7,成本更高時得另訂但不得低於 ×5 且須說明理由 - 文件控制表「下次審查日」為既有漂移,依審查裁定維持現狀不動(最小 diff) 測試:無(SOP 文件變更) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
#906(GameScene strangler 拆分)兩席審查(Grok 96/95 APPROVE、Sonnet 93/91 REQUEST_CHANGES)確認拆分本體無行為回歸,必修項全為文件層級。#906 已由 PM 合併,本 PR 承載全部文件層級收斂;#906 的 PR 描述已同步改寫(證據階層重排+移除「characterization test 先行鎖定」措辭)。
六項處置
starburstDirector.ts:8(seenFlavorHints→sceneEvents)外,rg全庫掃描搬走符號另找出 12 處:main.ts(syncGateSweep→levelGate.sweep)、stage.ts×3(掃掠基準歸屬/鏡像命名)、caramelStatus.ts(sync 呼叫者→damageDirector)、boss.ts/syrona.ts/bossRoom.ts(getVentLift/updateBuffHud 逐幀委派者→damageDirector)、stageModel.ts+docs/design/04-levels-world.md(spawnGate→門生成當幀)、04-levels-world.md(advanceTide 歸屬)、03-enemies-bosses.md(getVentLift 委派者);「」引述綁定字串零變更,design-docs 守門通過db07e8fd6↔ post-refactor(starpuff): W2 前置債務車——GameScene strangler 拆分 1180→875 行(行為零改變) #906,mid bot 各 4 輪逐輪交替):兩側皆 4/4 通關;TTK base 16.6–22.6s(中位 19.5)vs branch 15.4–19.7s(中位 18.4),包絡重疊;靜態軸全等(d 3.5/m 3.5/pStatic 3.8)。裁決依據採 clearRate+靜態軸(理由:與本輪同步入 SOP 的證據階層一致——TTK 屬 bot 動態指標,作為支持性觀測而非裁決真值),原單點對照 18.9→17.5 由本包絡取代pre-rebase/<branch>ref 供 patch-id 覆核)(b) 難度驗收證據階層(bot 勝率非裁決真值;若必須用,比照 Lighthouse 序列化真值:單機序列 ×N 取中位+穩定性前證)(c) strangler 兩段式 commit 慣例(①模組+測試 ②切 wiring,使測試先行在 git 史可證;不採者敘事必須誠實)驗證
tsc --noEmit0 錯;lint 0 error;GameScene 維持 875 行Made with Cursor