Fix cookie processing issues#4586
Merged
Merged
Conversation
Contributor
Author
|
Note that regular responses with code 500 will still set state cookies. |
Marsup
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #4297, #4527 and #4316.
Not allowing cookies to be set on error 500 responses is an API change, but unlikely to affect usage. I made an effort to preserve cookie clears, since it can help avoid processing errors on future requests, and it doesn't have the same risk as setting a full cookie.
Not setting
autoValuecookies when state parsing is disabled is not an API change as such, since this is how it already works in practice.