Skip to content

deps: update ggml for OpenCL Q4_0 fixes#1

Open
happyyzy wants to merge 1 commit into
agent/sdcpp-upstream-base-20260712from
agent/sdcpp-ggml-q4-fix
Open

deps: update ggml for OpenCL Q4_0 fixes#1
happyyzy wants to merge 1 commit into
agent/sdcpp-upstream-base-20260712from
agent/sdcpp-ggml-q4-fix

Conversation

@happyyzy

Copy link
Copy Markdown
Owner

Summary

Updates the ggml submodule pointer to the local staging branch for the OpenCL Q4_0 / Adreno correctness fixes.

Corresponding ggml PR: happyyzy/ggml#2.

Notes

No stable-diffusion.cpp runtime code is changed in this PR; this is only the dependency pointer update.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2eebe8383b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ggml
@@ -1 +1 @@
Subproject commit 3af5f5760e19a96427f5f7a93b79cbdf3d4b265b
Subproject commit 02a0d864b8b5768a3ae8ab22ec54b08d289ed636

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin ggml to a fetchable commit

In a fresh checkout or CI run, this new gitlink cannot be fetched from the configured submodule remote: .gitmodules still points ggml at https://github.com/leejet/ggml.git, but 02a0d864b8b5768a3ae8ab22ec54b08d289ed636 is only reachable in the referenced happyyzy/ggml fork and the corresponding leejet/ggml commit page is not found. As a result, git submodule update --init ggml will fail before the project can build unless the submodule URL is updated or the commit is first made reachable from leejet/ggml.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant