Skip to content

deps: point ggml to Adreno xmem SDPA PR#3

Open
happyyzy wants to merge 1 commit into
agent/sdcpp-text-ctx-clifrom
agent/sdcpp-ggml-xmem-sdpa
Open

deps: point ggml to Adreno xmem SDPA PR#3
happyyzy wants to merge 1 commit into
agent/sdcpp-text-ctx-clifrom
agent/sdcpp-ggml-xmem-sdpa

Conversation

@happyyzy

Copy link
Copy Markdown
Owner

Summary

Updates the ggml submodule pointer to the local staging branch that adds the Adreno xmem SDPA path.

Corresponding ggml PR: happyyzy/ggml#3.

Notes

This PR is stacked on #2 and only updates the dependency pointer.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c7933d255

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ggml
@@ -1 +1 @@
Subproject commit 02a0d864b8b5768a3ae8ab22ec54b08d289ed636
Subproject commit 399ea717940d2008e70ead58a992b83d0745569f

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Point ggml at a commit from its configured remote

The submodule gitlink now points at 399ea717..., but .gitmodules still configures ggml to fetch from https://github.com/leejet/ggml.git; this SHA is available in happyyzy/ggml and not under leejet/ggml, so a fresh clone or CI job running git submodule update --init ggml from the configured URL cannot fetch the recorded commit. Please either push/merge the ggml commit to the configured remote or update the submodule URL/ref so the recorded SHA is fetchable.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant