Skip to content

Null pointer dereference suspected by coverity #1434

@chipitsine

Description

@chipitsine

Tool Name and Version

Coverity

Code Report

** CID 1465055:    (FORWARD_NULL)
/src/log.c: 2153 in sess_build_logline()
/src/log.c: 2123 in sess_build_logline()


________________________________________________________________________________________________________
*** CID 1465055:    (FORWARD_NULL)
/src/log.c: 2153 in sess_build_logline()
2147                                    break;
2148     
2149                            case  LOG_FMT_FRONTENDPORT: // %fp
2150                                    addr = (s ? si_dst(&s->si[0]) : sess_dst(sess));
2151                                    if (addr) {
2152                                            if (addr->ss_family == AF_UNIX)
>>>     CID 1465055:    (FORWARD_NULL)
>>>     Dereferencing null pointer "sess->listener".
2153                                                    ret = ltoa_o(sess->listener->luid, tmplog, dst + maxsize - tmplog);
2154                                            else
2155                                                    ret = lf_port(tmplog, (struct sockaddr *)addr, dst + maxsize - tmplog, tmp);
2156                                    }
2157                                    else
2158                                            ret = lf_text_len(tmplog, NULL, 0, dst + maxsize - tmplog, tmp);
/src/log.c: 2123 in sess_build_logline()
2117                                    break;
2118     
2119                            case LOG_FMT_CLIENTPORT:  // %cp
2120                                    addr = (s ? si_src(&s->si[0]) : sess_src(sess));
2121                                    if (addr) {
2122                                            if (addr->ss_family == AF_UNIX)
>>>     CID 1465055:    (FORWARD_NULL)
>>>     Dereferencing null pointer "sess->listener".
2123                                                    ret = ltoa_o(sess->listener->luid, tmplog, dst + maxsize - tmplog);
2124                                            else
2125                                                    ret = lf_port(tmplog, (struct sockaddr *)addr, dst + maxsize - tmplog, tmp);
2126                                    }
2127                                    else
2128                                            ret = lf_text_len(tmplog, NULL, 0, dst + maxsize - tmplog, tmp);


### Additional Information

_No response_

### Output of `haproxy -vv`

```plain
No

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: code-reportThis issue describes a code report (like valgrind or coverity)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions