src/quic_rx.c: null pointer dereference suspected by coverity

[chipitsine]

Tool Name and Version

coverity

Code Report

*** CID 1528841:  Null pointer dereferences  (REVERSE_INULL)
/src/quic_rx.c: 298 in qc_handle_newly_acked_frm()
292                     if (offset <= stream->ack_offset) {
293                             if (qc_stream_desc_ack(&stream, offset, len)) {
294                                     TRACE_DEVEL("stream consumed", QUIC_EV_CONN_ACKSTRM,
295                                                 qc, strm_frm, stream);
296                             }
297     
>>>     CID 1528841:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "stream" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
298                             if (!stream) {
299                                     /* no need to continue if stream freed. */
300                                     TRACE_DEVEL("stream released and freed", QUIC_EV_CONN_ACKSTRM, qc);
301                                     qc_release_frm(qc, frm);
302                                     qc_check_close_on_released_mux(qc);
303                                     break;

Additional Information

No response

Output of haproxy -vv

no

[haproxyFred]

As this code has not been logically modified (only moving, function renaming), I guess coverity should have already warned about such a false positive issue. This is the case here: #1671

[haproxyFred]

I guess coverity will detect again all the false positive cases in relation with the code which have been recently reworked/moved/renamed.