fix: reject non-aggregate columns not covered by GROUP BY#18
Merged
Conversation
Previously SELECT count(*), other_col FROM t silently returned an arbitrary row's value for other_col instead of erroring, unlike PostgreSQL. Also fixes expr_structurally_eq, which compared Expr via Debug output and so missed matches whenever spans differed, causing GROUP BY column lookups to spuriously fail.
harehare
force-pushed
the
fix/group-by-validation
branch
from
July 23, 2026 12:20
3b0a2dd to
1a91fcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously SELECT count(*), other_col FROM t silently returned an arbitrary row's value for other_col instead of erroring, unlike PostgreSQL. Also fixes expr_structurally_eq, which compared Expr via Debug output and so missed matches whenever spans differed, causing GROUP BY column lookups to spuriously fail.