✨ feat(lang): add -> (Arrow) syntax as shorthand for fn#1664
Merged
Conversation
Add Arrow (->) as an alternative syntax for anonymous functions, equivalent to fn. Includes lexer token, CST/AST parser support, formatter support, and tests for all layers. Also fix CST parse_arg() to accept Arrow tokens so -> can be used as a function call argument (e.g. map(->(): ...)).
Contributor
There was a problem hiding this comment.
Pull request overview
Adds -> (Arrow) as an alternative surface syntax for anonymous functions in mq-lang, integrating it through lexing, CST/AST parsing, and formatting, with accompanying tests to ensure consistent behavior across layers.
Changes:
- Introduce
TokenKind::Arrowand lex->as its own token. - Extend CST and AST parsers to treat
Arrowequivalently tofn, including allowing it as a call argument. - Add formatter test coverage for arrow-function formatting scenarios.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/mq-lang/src/lexer/token.rs | Adds TokenKind::Arrow and display formatting/tests for ->. |
| crates/mq-lang/src/lexer.rs | Adds lexer support and tokenization tests for the -> token. |
| crates/mq-lang/src/cst/parser.rs | Allows -> wherever fn is accepted (including call args) and adds CST tests. |
| crates/mq-lang/src/ast/parser.rs | Accepts -> as a fn equivalent in the AST parser and adds AST tests. |
| crates/mq-formatter/src/formatter.rs | Adds formatter tests validating arrow-function output and spacing/newline behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Arrow (->) as an alternative syntax for anonymous functions, equivalent to fn. Includes lexer token, CST/AST parser support, formatter support, and tests for all layers.
Also fix CST parse_arg() to accept Arrow tokens so -> can be used as a function call argument (e.g. map(->(): ...)).